[BEAM-7974] Make RowCoder @Internal

• Type: Improvement
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Component/s: sdk-java-core
• Labels: Clarified
• Assignee: Unassigned
• Reporter: Brian Hulette
• Created: 14/Aug/19 00:51
• Updated: 04/Jun/22 12:47

Description

RowCoder is currently public in sdk.coders, tempting people to use it directly. But the Schemas API is written such that everyone should be using SchemaCoder, and RowCoder should be an implementation detail.

Unfortunately this isn't a trivial change, I tried to do it and resolve the few dependencies that cropped up, but running RowCoderTest yielded the following error:

tried to access class org.apache.beam.sdk.schemas.RowCoderGenerator$EncodeInstruction from class org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3
java.lang.IllegalAccessError: tried to access class org.apache.beam.sdk.schemas.RowCoderGenerator$EncodeInstruction from class org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3
	at org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3.encode(Unknown Source)
	at org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3.encode(Unknown Source)
	at org.apache.beam.sdk.schemas.RowCoder.encode(RowCoder.java:159)
	at org.apache.beam.sdk.schemas.RowCoder.encode(RowCoder.java:54)
	at org.apache.beam.sdk.coders.Coder.encode(Coder.java:136)
	at org.apache.beam.sdk.testing.CoderProperties.encode(CoderProperties.java:334)
	at org.apache.beam.sdk.testing.CoderProperties.decodeEncode(CoderProperties.java:362)
	at org.apache.beam.sdk.testing.CoderProperties.coderDecodeEncodeEqualInContext(CoderProperties.java:104)
	at org.apache.beam.sdk.testing.CoderProperties.coderDecodeEncodeEqual(CoderProperties.java:94)

My attempt is available at https://github.com/TheNeuralBit/beam/commit/869b8c6ba2f554bf56d8df70a754b76ef38dbc89