[BEAM-7732] Allow access to SpannerOptions in Beam

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Won't Fix
• Affects Version/s: 2.12.0, 2.13.0
• Fix Version/s: Not applicable
• Component/s: io-java-gcp
• Assignee: Niel Markwick
• Reporter: Niel Markwick
• Created: 12/Jul/19 12:47
• Updated: 28/Jun/20 08:16
• Resolved: 28/Jun/20 08:16

Description

Beam hides the SpannerOptions object behind a SpannerConfig object because the SpannerOptions object is not serializable.

This means that the only options that can be set are those that can be specified in SpannerConfig - limited to host, project, instance, database.

Suggestion: add the possibility to set a SpannerOptionsFactory in SpannerConfig:

public interface SpannerOptionsFactory extends Serializable {
   public SpannerOptions create();
}

This would allow the user use this factory class to specify custom SpannerOptions before they are passed onto the connectToSpanner() method; 

connectToSpanner() would then become: 

public SpannerAccessor connectToSpanner() {
  
  SpannerOptions.Builder builder = spannerOptionsFactory.create().toBuilder();
  // rest of connectToSpanner follows, setting project, host, etc.

 

Issue Links

• links to: GitHub Pull Request #9048