[BEAM-7629] Improve DoFn method validation in core/graph/fn.go

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: sdk-go
• Assignee: Daniel Oliveira
• Reporter: Daniel Oliveira
• Created: 25/Jun/19 01:07
• Updated: 16/May/20 14:07
• Resolved: 11/Dec/19 22:18

Description

Various improvements can be made to validating the signatures and type usages in DoFns. Some things that should probably be checked:

• Check that StartBundle and FinishBundle contain any emit parameters and side inputs present in ProcessElement
• Check that any side inputs/emits have correctly matching types between Start/FinishBundle and ProcessElement
• Check that parameters and return values for the various methods are valid (for ex. Teardown/Setup should have no params)

Issue Links

• links to: GitHub Pull Request #8936
• links to: GitHub Pull Request #9609