Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-7507

StreamingDataflowWorker attempts to decode non-utf8 binary data as utf8

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.14.0
    • Component/s: runner-dataflow
    • Labels:
      None

      Description

      In StreamingDataflowWorker, when setting the workId for the logging MDC, currently the code attempts to decode a binary blob as utf8.  This will (generally) cause a decoding error, and the java UTF8 decoder uses a globally synchronized cache to handle generating these error results.

      A simple solution would be to use the protobuf TextFormat escaping to convert the ByteString key into a string.

        Attachments

          Activity

            People

            • Assignee:
              SteveNiemitz Steve Niemitz
              Reporter:
              SteveNiemitz Steve Niemitz

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1.5h
                1.5h

                  Issue deployment