Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-7009

Add Go SDK test for Standard Coders using the yaml data.

Details

    • Bug
    • Status: Resolved
    • P1
    • Resolution: Fixed
    • None
    • Missing
    • beam-model, sdk-go

    Description

      The Go SDK doesn't currently do this validation, against the standard yaml file. [1]
      The Java and Python equivalents of the test can be found from here [2].
       
      Care would need to be taken so that Beam Go SDK users (such as they are) aren't forced to run them, and not have the yaml file to read. I'd suggest putting it with the integration tests [3].

      The other thing of note is that the Go SDK has no notion of "nested" vs "unnested" coders. All coders are "nested" in the Go SDK, and should have their lengths prefixed to them as appropriate.

      1: https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
      2: https://github.com/apache/beam/search?q=standard_coders.yaml&unscoped_q=standard_coders.yaml
      3: https://github.com/apache/beam/tree/master/sdks/go/test 

      Attachments

        Issue Links

          Activity

            People

              lostluck Robert Burke
              lostluck Robert Burke
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 8h
                  8h