Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-697

TextIO withHeader() and withFooter() overwrite validation setting to false

Details

    • Bug
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • 0.2.0-incubating, 0.3.0-incubating
    • 0.3.0-incubating
    • beam-model
    • None

    Description

      TextIO.Write.Bound.withHeader() and TextIO.Write.Bound.withFooter() both pass a literal value of false to the constructor's validate parameter for the returned Bound instance. This could, obviously, lead to unintended behavior wrt pipeline validation. Looks like a simple copy and paste error from TextIO.Write.Bound.withoutValidation()

      I'm about to push another iteration for a PR for BEAM-55 and have included the trivial fix for this bug it in that set of changes. Creating this in case my PR is not accepted right away. Please close if this issue is wholly unnecessary. Thanks!

      Attachments

        Issue Links

          Activity

            People

              jeffkpayne@gmail.com Jeffrey Payne
              jeffkpayne@gmail.com Jeffrey Payne
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: