Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-6947

TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone offset and the timezone offset on 2nd of Jan 1970 differ

Details

    • Bug
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-py-core
    • None

    Description

      The test TestGCSIO.test_last_updated uses timestamp 123456.78 as the last updated timestamp.  This timestamp is converted into a naive datetime in the Fakefile class get_metadata method (gcsio_test.py line 72) Then in the GcsIO class last_updated method (gcsio.py ) is converted back to timestamp. But the conversion is incorrect when the the timezone offset is different in 1970 and now. In my case now Singapore is GMT+8 and it was only GMT+7:30 in 1970. So the test fails. 

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              csabakassai Csaba Kassai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h