Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-6904

Test all Coder structuralValue implementations

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Open
    • Priority: P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: sdk-java-core

      Description

      Here is a test helper that check that structuralValue is consistent with equals: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L200

      And here is one that tests it another way: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L226

      With the deprecation of consistentWithEquals and implementing all the structualValue methods, we should add these tests to every coder.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kenn Kenneth Knowles
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 5h 10m
                5h 10m