Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-672

Figure out TestPipeline.create(PipelineOptions) / TestPipeline.fromOptions(PipelineOptions) story

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-java-core

    Description

      TestPipeline integrates with the integration testing environment and relies heavily on being able to be configured by the environment and executed on many runners.

      Tests which rely on mutating PipelineOptions before creating the TestPipeline easily can get the integration wrong by creating PipelineOptions from PipelineOptionsFactory and then calling either TestPipeline.create(options) or TestPipeline.fromOptions(options), thus ignoring any integration environment pipeline options specified.

      We should fix the exposed methods on TestPipeline to prevent users from making this simple mistake.

      One suggestion is to create a TestPipeline builder which will give access to a mutable PipelineOptions which the user can edit before calling build() creating a TestPipeline.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              lcwik Luke Cwik
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: