[BEAM-672] Figure out TestPipeline.create(PipelineOptions) / TestPipeline.fromOptions(PipelineOptions) story

• Type: Improvement
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Component/s: sdk-java-core
• Labels: Clarified test
• Assignee: Unassigned
• Reporter: Luke Cwik
• Created: 23/Sep/16 22:16
• Updated: 03/Jun/22 16:14

Description

TestPipeline integrates with the integration testing environment and relies heavily on being able to be configured by the environment and executed on many runners.

Tests which rely on mutating PipelineOptions before creating the TestPipeline easily can get the integration wrong by creating PipelineOptions from PipelineOptionsFactory and then calling either TestPipeline.create(options) or TestPipeline.fromOptions(options), thus ignoring any integration environment pipeline options specified.

We should fix the exposed methods on TestPipeline to prevent users from making this simple mistake.

One suggestion is to create a TestPipeline builder which will give access to a mutable PipelineOptions which the user can edit before calling build() creating a TestPipeline.

Issue Links

• is related to: BEAM-298 Make TestPipeline implement the TestRule interface