Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-4778

Less wasteful ArtifactStagingService

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: runner-core
    • Labels:

      Description

      https://github.com/apache/beam/blob/master/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactStagingService.java is the main implementation of ArtifactStagingService.

      It stages artifacts into a directory; and in practice the passed staging session token is such that the directory is different for every job. This leads to 2 issues:

      • It doesn't get cleaned up when the job finishes or even when the JobService shuts down, so we have disk space leaks if running a lot of jobs (e.g. a suite of ValidatesRunner tests)
      • We repeatedly re-stage the same artifacts. Instead, ideally, we should identify that some artifacts don't need to be staged - based on knowing their md5. The artifact staging protocol has rudimentary support for this but may need to be modified.

      CC: Ankur Goenka

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rdub Ryan Williams
                Reporter:
                jkff Eugene Kirpichov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 6.5h
                  6.5h