Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-4422

:sdks:go:goVet fails

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • build-system
    • None

    Description

      The following fails for me with "./gradlew check":
       
      Execution failed for task ':beam-sdks-go:vet'.
      > Build failed due to return code 1 of:
        Command:
         /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet /home/coheig/src/apache/beam/sdks/go/test /home/coheig/src/apache/beam/sdks/go/pkg /home/coheig/src/apache/beam/sdks/go/data /home/coheig/src/apache/beam/sdks/go/cmd /home/coheig/src/apache/beam/sdks/go/build /home/coheig/src/apache/beam/sdks/go/examples /home/coheig/src/apache/beam/sdks/go/container
        Env:
         GOEXE=
         GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
         GOROOT=/home/coheig/.gradle/go/binary/1.10/go
         GOOS=linux
         GOARCH=amd64
       
      herohde provided more information on the mailing list:
       
      the error is "go vet" itself failing due to analyzing our dependencies under vendor: 
      /Users/herohde/go/src/github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47: Fprintln arg list ends with redundant newline

      /Users/herohde/go/src/github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54: unreachable code

      /Users/herohde/go/src/github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276: unreachable code
      [...]
       Not sure whether this is something we can fix in our configuration or whether it's rather a bug in the gogradle plugin. Given that there are no go vet problems in our code, we'd want that check to pass.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              coheigea Colm O hEigeartaigh
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: