Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-4339

Enforce ErrorProne analysis in the elasticsearch IO project

    Details

      Description

      Java ErrorProne static analysis was recently enabled in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to make sdks-java-core ErrorProne-clean and add enforcement. This task is clean ErrorProne warnings and add enforcement in beam-sdks-java-io-elasticsearch and related project. Additional context discussed on the dev list.

      Fixing this issue will involve:

      1. Follow instructions in the Contribution Guide to set up a beam development environment.
      2. Run the following command to compile and run ErrorProne analysis on the project: ./gradlew :beam-sdks-java-io-elasticsearch:assemble :beam-sdks-java-io-elasticsearch-tests-2:assemble :beam-sdks-java-io-elasticsearch-tests-5:assemble :beam-sdks-java-io-elasticsearch-tests-common:assemble
      3. Fix each ErrorProne warning from the sdks/java/io/elasticsearch* projects.
      4. In sdks/java/io/elasticsearch/build.gradle, sdks/java/io/elasticsearch-tests/elasticsearch-tests-2/build.gradle, and sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/build.gradle, and sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/build.gradle, add failOnWarning: true to the call the applyJavaNature() (example).

      This starter issue is sponsored by Scott Wegner. Feel free to reach out with questions or code review:

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                timrobertson100 Tim Robertson
                Reporter:
                swegner Scott Wegner
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m