[BEAM-4309] Enforce ErrorProne analysis in direct-runner project

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Component/s: runner-direct
• Labels: errorprone starter
• Assignee: Scott Wegner
• Reporter: Scott Wegner
• Created: 16/May/18 22:17
• Updated: 16/May/20 13:23
• Resolved: 15/Jun/18 12:00

Description

Java ErrorProne static analysis was recently enabled in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to make sdks-java-core ErrorProne-clean and add enforcement. This task is clean ErrorProne warnings and add enforcement in beam-runners-direct-java. Additional context discussed on the dev list.

Fixing this issue will involve:

1. Follow instructions in the Contribution Guide to set up a beam development environment.
2. Run the following command to compile and run ErrorProne analysis on the project: ./gradlew :beam-runners-direct-java:assemble
3. Fix each ErrorProne warning from the runners/direct-java project.
4. In runners/direct-java/build.gradle, add failOnWarning: true to the call the applyJavaNature() (example).

This starter issue is sponsored by swegner. Feel free to reach out with questions or code review:

• JIRA: swegner
• GitHub: @swegner
• Slack: @Scott Wegner
• Email: swegner at google dot com

Issue Links

• is cloned by: BEAM-4556 Enforce ErrorProne analysis in sdks-java-core project
• relates to: BEAM-4563 Fix FutureReturnValueIgnored violations in direct runner
• links to: GitHub Pull Request #5644