[BEAM-3608] Vendor Guava

• Type: Sub-task
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.10.0
• Component/s: runner-core, sdk-java-core
• Labels: Done
• Assignee: Kenneth Knowles
• Reporter: Kenneth Knowles
• Created: 02/Feb/18 14:42
• Updated: 06/Oct/20 21:55
• Resolved: 22/Feb/19 02:45

Description

Instead of shading as part of our build, we can shade before build so that it is apparent when reading code, and in IDEs, that a particular class resides in a hidden namespace.

import com.google.common.reflect.TypeToken

becomes something like

import org.apache.beam.private.guava21.com.google.common.reflect.TypeToken

So we can very trivially ban `org.apache.beam.private` from public APIs unless they are annotated @Internal, and it makes sharing between our own modules never get broken by shading again.

Issue Links

• blocks: BEAM-4484 Shading model-pipeline / model-fn-execution / model-job-management produces corrupted classes
• is related to: BEAM-6420 Vendored Guava hits some errorprone issues
• relates to: BEAM-4753 Reuse validateShadedJarDoesntLeakNonOrgApacheBeamClasses across all subprojects which perform shading
• links to: GitHub Pull Request #5570
• links to: GitHub Pull Request #6809
• links to: GitHub Pull Request #7109
• links to: GitHub Pull Request #7111
• links to: GitHub Pull Request #7494
• links to: GitHub Pull Request #9318