Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-3581

[SQL] Support for Non-ASCII chars is flaky

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Not applicable
    • Component/s: dsl-sql
    • Labels:
      None

      Description

      Beam SQL overrides default charset that Calcite uses and sets it to UTF16. It is done via system properties.

      Problem is that we do this only when it hasn't been set yet. So if system property has been set to ISO-8859-1 (Calcite's default), then test runs will fail when trying to encode characters not supported in that encoding.

      Solution:

       - because it's a system property, we don't want to force override it;

       - for the same reason we cannot set it for a specific query execution;

       - we can expose a static method on BeamSql to override these properties if explicitly requested;

       - affected tests will explicitly override it;

       - otherwise behavior will stay unchanged and we will respect defaults and user settings;

        Attachments

          Activity

            People

            • Assignee:
              kedin Anton Kedin
              Reporter:
              kedin Anton Kedin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m