[BEAM-2303] Add SpecificData to AvroCoder

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.30.0
• Component/s: sdk-java-core
• Labels: Clarified
• Assignee: Vitaly Terentyev
• Reporter: Arvid Heise
• Created: 16/May/17 10:18
• Updated: 16/Jul/21 15:00
• Resolved: 12/Apr/21 19:26

Description

The AvroCoder currently supports GenericData and ReflectData, but not SpecificData.

It should relatively easy to incorporate it by expanding the logic while constructing the Reader and Writer by also checking if the type implements the SpecificRecord interface. It would greatly speed up (de-)serialization of Avro-generated java classes.

            return myCoder.getType().equals(GenericRecord.class)
                ? new GenericDatumReader<T>(myCoder.getSchema())
                : new ReflectDatumReader<T>(
                    myCoder.getSchema(), myCoder.getSchema(), myCoder.reflectData.get());

should be

                        if (myCoder.getType().equals(GenericRecord.class)) {
                            return new GenericDatumReader<T>(myCoder.getSchema());
                        }
                        if (SpecificRecord.class.isAssignableFrom(myCoder.getType())) {
                            return new SpecificDatumReader<T>(myCoder.getType());
                        }
                        return new ReflectDatumReader<T>(
                                myCoder.getSchema(), myCoder.getSchema(), myCoder.reflectData.get());

Issue Links

• links to: GitHub Pull Request #14410