[BEAM-1656] DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: P2
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 2.0.0
Component/s: runner-direct
Labels:
None

Description

In [getReader](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L174) we call finalize on the checkpoint that arrived in the incoming shard. Then later in [finishRead](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L205) we finalize the old checkpoint again.

Attachments

Issue Links

contains

BEAM-1653 Error when using PubsubIO with the DirectRunner

Resolved

is duplicated by

BEAM-1977 PubsubIO fails with NPE on ACK when running locally

Resolved

is related to

BEAM-1659 Improve UnboundedSourceShard structure

Open

links to

GitHub Pull Request #2237

Activity

People

Assignee:: Thomas Groh

Reporter:: Ben Chambers

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 08/Mar/17 18:39

Updated:: 16/May/20 13:55

Resolved:: 14/Mar/17 17:47