Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-1414

CountingInput should comply with PTransform style guide

    XMLWordPrintableJSON

    Details

      Description

      Suggested changes:

      • Rename the whole class and its inner transforms to sound more verb-like, e.g.: GenerateRange.Bounded/Unbounded (as opposed to current CountingInput.BoundedCountingInput)
      • Provide a more unified API between bounded and unbounded cases: GenerateRange.from(100) should return a GenerateRange.Unbounded; GenerateRange.from(100).to(200) should return a GenerateRange.Bounded. They both should accept a timestampFn. The unbounded one should not have a withMaxNumRecords builder - that's redundant with specifying the range.
      • (optional) Use AutoValue

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jkff Eugene Kirpichov
                Reporter:
                jkff Eugene Kirpichov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: