[BEAM-1414] CountingInput should comply with PTransform style guide

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: sdk-java-core
• Labels: backward-incompatible starter
• Assignee: Eugene Kirpichov
• Reporter: Eugene Kirpichov
• Created: 07/Feb/17 21:47
• Updated: 21/Apr/17 23:57
• Resolved: 21/Apr/17 23:57

Description

Suggested changes:

• Rename the whole class and its inner transforms to sound more verb-like, e.g.: GenerateRange.Bounded/Unbounded (as opposed to current CountingInput.BoundedCountingInput)
• Provide a more unified API between bounded and unbounded cases: GenerateRange.from(100) should return a GenerateRange.Unbounded; GenerateRange.from(100).to(200) should return a GenerateRange.Bounded. They both should accept a timestampFn. The unbounded one should not have a withMaxNumRecords builder - that's redundant with specifying the range.
• (optional) Use AutoValue

Issue Links

• is duplicated by: BEAM-709 Migrate CountingSource/CountingInput to use AutoValue to reduce boilerplate
• is part of: BEAM-1353 Beam should comply with PTransform style guide
• links to: GitHub Pull Request #2601