[BEAM-13460] IsmSideInputReaderTest.verifyMap does not make some contains assertions

• Type: Bug
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Component/s: runner-dataflow
• Assignee: Unassigned
• Reporter: Brian Hulette
• Created: 14/Dec/21 18:38
• Updated: 04/Jun/22 22:37

Description

See for example https://github.com/apache/beam/blob/a8162f2fe92fbc982f72289dfca7b56f1fdb0762/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java#L1579

There are three such "assertions" in verifyMap. When these are made into actual assertions (e.g. using assertTrue), the test fails.

Issue Links

• Discovered while testing: BEAM-13271 error-prone UnusedVariable check raises false positives for StateId and TimerId usages