Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-13431

Use ProjectionConsumer in FieldAccessVisitor.

Details

    • Improvement
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-java-core
    • None

    Description

      I created an interface for ProjectionConsumer and then neglected to use it. Using ProjectionConsumer rather than handling transforms case-by-case will make FieldAccessVisitor easier to extend.

      Changing this would require ParDo.MultiOutput to implement ProjectionConsumer.

      https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/ProjectionConsumer.java

      https://github.com/apache/beam/blob/8a7ad0edd0ffe2a7b23efbe37567cf03aed82262/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/FieldAccessVisitor.java#L64

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ibzib Kyle Weaver
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: