[BEAM-13271] error-prone UnusedVariable check raises false positives for StateId and TimerId usages

• Type: Task
• Status: Triage Needed
• Priority: P3
• Resolution: Unresolved
• Component/s: sdk-java-core
• Assignee: Unassigned
• Reporter: Brian Hulette
• Created: 17/Nov/21 23:54
• Updated: 22/Nov/24 15:31

Description

See https://github.com/google/error-prone/issues/2668. The next release of error-prone will contain https://github.com/google/error-prone/pull/2669 and https://github.com/google/error-prone/pull/2676, which will help us.

Until then we've had to suppress the check in several places. This jira tracks upgrading to a new error-prone once released and removing the suppressions.

Issue Links

• is blocked by: BEAM-13814 Run errorprone with Java 11 (required in 2.11.0 and newer)
• relates to: BEAM-11936 Fix errorprone ignored warnings
• Testing discovered: BEAM-13460 IsmSideInputReaderTest.verifyMap does not make some contains assertions
• links to: GitHub Pull Request #16231
• links to: GitHub Pull Request #16637