[BEAM-12975] PythonLint PreCommit is broken

• Type: Improvement
• Status: Resolved
• Priority: P1
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: test-failures
• Labels: currently-failing
• Assignee: Unassigned
• Reporter: Brian Hulette
• Created: 27/Sep/21 18:22
• Updated: 29/Sep/21 15:58
• Resolved: 29/Sep/21 15:58

Description

PythonLint precommit started failing in the last build: https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/2859

Failure is in py37-mypy:

05:09:46 apache_beam/testing/load_tests/load_test_metrics_utils.py:51: error: unused 'type: ignore' comment
05:09:46 apache_beam/testing/load_tests/load_test_metrics_utils.py:55: error: Incompatible types in assignment (expression has type "None", variable has type Module)  [assignment]
05:09:46 apache_beam/testing/load_tests/load_test_metrics_utils.py:56: error: Cannot assign to a type  [misc]
05:09:46 apache_beam/testing/load_tests/load_test_metrics_utils.py:56: error: Incompatible types in assignment (expression has type "None", variable has type "Type[SchemaField]")  [assignment]

I think this can be attributed to a minor version upgrade in google-cloud-bigquery (possibly they added typehints?). Failing build is using google-cloud-bigquery==2.27.0, while the previous passing build is using 2.26.0.