[BEAM-12736] Protobuf schema provider row functions break on camel-case field names

• Type: Bug
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Affects Version/s: 2.31.0
• Component/s: extensions-java-protobuf
• Assignee: Unassigned
• Reporter: Chris Hinds
• Created: 10/Aug/21 16:49
• Updated: 04/Jun/22 21:01

Description

ProtoByteBuddyUtils.protoGetterName() depends on field names being snake-case. But the Protobuf style guide only recommends that field names are so defined.  

Snake-case is not enforced by protoc and my team have always created proto field names in camel-case (perhaps we didn't understand that protoc would automatically rewrite field names for us). It is likely that we are not alone.

If one calls a row function against a proto instance whose field were defined in camel-case, an IllegalArgumentException results from the ProtoByteBuddyUtils snake-case assumption.

SerializableFunction myRowFunction = new ProtoMessageSchema().toRowFunction(new TypeDescriptor<MyDataModel.ProtoPayload>() {});
MyDataModel.ProtoPayload payload = …
Row row = (Row) myRowFunction.apply(payload);

Issue Links

• links to: GitHub Pull Request #15306