Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-12528

Don't reuse failed plans.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.32.0
    • Component/s: sdk-go
    • Labels:
      None

      Description

      Failed plans get re-appended to the list of plans unconditionally.
       
      https://github.com/apache/beam/blob/cf8ffe660cfcb1f7d421171f406fa991b93e043b/sdks/go/pkg/beam/core/runtime/harness/harness.go#L315
       
      Which means there's a risk that a new bundle using the same bundle descriptor might re-use a failed plan. 
       
      https://github.com/apache/beam/blob/cf8ffe660cfcb1f7d421171f406fa991b93e043b/sdks/go/pkg/beam/core/runtime/harness/harness.go#L236
       
      While users should be resetting everything in StartBundle, that's not necessarily the case. It would be easier on users when plans are re-used to recreate them on failures.
       
      After a certain point plans are garbage collected already, both failed and successful.
       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lostluck Robert Burke
                Reporter:
                lostluck Robert Burke
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h