[BEAM-12516] StreamingDataflowWorker.ShardedKey.toString throws exception if key is less than 100 bytes

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.28.0
• Fix Version/s: 2.32.0
• Component/s: runner-dataflow
• Assignee: Sam Whittle
• Reporter: Sam Whittle
• Created: 21/Jun/21 11:19
• Updated: 09/Jul/21 21:18
• Resolved: 09/Jul/21 21:18

Description

ByteString.substring does not support an end index beyond the string length.

example exception:

SLF4J: Failed toString() invocation on an object of type [org.apache.beam.runners.dataflow.worker.AutoValue_StreamingDataflowWorker_ShardedKey]

java.lang.IndexOutOfBoundsException: End index: 100 >= 3
org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString.checkRange(ByteString.java:1272)
org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString$LiteralByteString.substring(ByteString.java:1343)
org.apache.beam.runners.dataflow.worker.StreamingDataflowWorker$ShardedKey.toString(StreamingDataflowWorker.java:1144)
at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:277)
at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:249)
at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:211)
at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:161)
at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:151)
at org.slf4j.impl.JDK14LoggerAdapter.error(JDK14LoggerAdapter.java:522)
at org.apache.beam.runners.dataflow.worker.StreamingDataflowWorker$ComputationState.invalidateStuckCommits(StreamingDataflowWorker.java:2326)

Issue Links

• links to: GitHub Pull Request #15050