[BEAM-12248] Reduce ArrayList allocation in Row/RowUtils

• Type: Task
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.30.0
• Component/s: sdk-java-core
• Assignee: Daniel Kulp
• Reporter: Daniel Kulp
• Created: 28/Apr/21 18:21
• Updated: 29/Apr/21 06:15
• Resolved: 29/Apr/21 06:15

Description

In Row.Builder.build, it currently creates a FieldOverrides object, then sets the overrides, and then will sometimes (if empty) discard everything it just did.

This can be optimized a bit by:
1) Only create the FieldOverrides if the values is not empty.

2) Pass the values in to FieldOverrides constructor so that the appropriate ArrayList can be filled created and filled in immediately. The current setup will cause an empty ArrayList to be created in the constructor and then immediately discarded in the setOverride call.

Issue Links

• links to: GitHub Pull Request #14672