[BEAM-12081] Fix AwsOptions Jackson (de)serialization of integer values

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.28.0
• Fix Version/s: 2.30.0
• Component/s: io-java-aws
• Assignee: Bulat Shakirzyanov
• Reporter: Bulat Shakirzyanov
• Created: 01/Apr/21 01:09
• Updated: 01/Apr/21 16:38
• Resolved: 01/Apr/21 16:38

Description

Minimal test case to reproduce:

AwsOptions awsOptions = PipelineOptionsTranslation
        .fromProto(PipelineOptionsTranslation.toProto(PipelineOptionsFactory
                .fromArgs("--clientConfiguration={ \"proxyPort\": -1 }")
                .create()
        ))
        .as(AwsOptions.class);
System.out.println(awsOptions.getClientConfiguration());

Stacktrace:

java.lang.Double cannot be cast to java.lang.Integer
java.lang.ClassCastException: java.lang.Double cannot be cast to java.lang.Integer
	at org.apache.beam.sdk.io.aws.options.AwsModule$AwsHttpClientConfigurationDeserializer.deserialize(AwsModule.java:303)
	at org.apache.beam.sdk.io.aws.options.AwsModule$AwsHttpClientConfigurationDeserializer.deserialize(AwsModule.java:290)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4202)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3205)
	at org.apache.beam.sdk.options.ProxyInvocationHandler.getValueFromJson(ProxyInvocationHandler.java:511)
	at org.apache.beam.sdk.options.ProxyInvocationHandler.invoke(ProxyInvocationHandler.java:170)
	at com.sun.proxy.$Proxy59.getClientConfiguration(Unknown Source)

Culprit:

https://github.com/apache/beam/blob/v2.28.0/sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsModule.java#L303

Explanation:

Jackson messages serialize numeric values as doubles. When options are later deserialized from that format, the value of "proxyPort" is "-1.0" and not "-1", leading to:

(Integer) Double.valueOf(-1.0)

 

Issue Links

• links to: GitHub Pull Request #14400