[BEAM-11067] Source not included on Java SDK docker image for some GPL/LGPL/MPL dependencies, like saxon-he and jformatstring

• Type: Bug
• Status: Resolved
• Priority: P1
• Resolution: Fixed
• Affects Version/s: 2.25.0
• Fix Version/s: Missing
• Component/s: build-system
• Assignee: Alan Myrvold
• Reporter: Alan Myrvold
• Created: 14/Oct/20 20:03
• Updated: 13/Jan/22 21:49
• Resolved: 15/May/21 18:01

Description

The java sdk docker image attempts to include source for GPL/LGPL/MPL/CDDL dependencies, but misses several.

./gradlew -Pdocker-pull-licenses :sdks:java:container:docker --info

the problem seems to be in the check for the license type:

https://github.com/alanmyrvold/beam/blob/c921b0c8384809dbcab3edcd5007e92da25067c6/sdks/java/container/license_scripts/pull_licenses_java.py#L41

SOURCE_CODE_REQUIRED_LICENSES = ['lgpl', 'glp', 'cddl', 'mpl']

Some of the license types in the beam_java_dependency_list.csv.gz spell out the license name, like "GNU Lesser" and don't match.

spotbugs-4.0.6,https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html,"GNU LESSER GENERAL PUBLIC LICENSE, Version 2.1",False

jformatstring-3.0.0,http://www.gnu.org/licenses/lgpl.html,GNU Lesser Public License,False

spotbugs-annotations-4.0.6,https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html,"GNU LESSER GENERAL PUBLIC LICENSE, Version 2.1",False

saxon-he-9.9.1-2,http://www.mozilla.org/MPL/2.0/,Mozilla Public License Version 2.0,False

saxon-he-9.9.1-4,http://www.mozilla.org/MPL/2.0/,Mozilla Public License Version 2.0,False

checkstyle-8.23,http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt,LGPL-2.1+,True

javassist-3.24.0-GA,http://www.mozilla.org/MPL/MPL-1.1.html,MPL 1.1,True

Issue Links

• links to: GitHub Pull Request #13117