Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-11024

Visit composite transform nodes in Pipeline._check_replacement()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: P2
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: sdk-py-core
    • Labels:

      Description

      Pipeline.replace_all() calls _replace(), which replaces transform nodes using a PipelineVisitor, and then _check_replacement(), which validates that there are no replaceable transform nodes using a PipelineVisitor i.e. it checks that PTransformOverride.matches() does not return True on any nodes.

      Currently, _replace() visits both composite and leaf transform nodes whereas _check_replacement() visits only leaf transform nodes. _check_replacement() should visit composite transform nodes as well for symmetry.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              myffical@gmail.com Yifan Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: