[BEAM-10783] ZetaSQL failed on WITH queries because wrong ref column index calculated in JoinScanWithRefConverter

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.25.0
• Component/s: dsl-sql-zetasql
• Assignee: Robin Qiu
• Reporter: Robin Qiu
• Created: 21/Aug/20 00:48
• Updated: 15/May/21 17:59
• Resolved: 15/May/21 17:59

Description

Some WITH queries, like:

WITH t1 AS (select 1 AS k), t2 AS (select 1 AS k), t3 AS (select 1 AS k)
SELECT COUNT(*)
FROM t1 JOIN t3 USING (k)

failed on ZetaSQL because how column index is calculated in JoinScanWithRefConverter is not correct.

 

In fact, the other converter responsible for JOINs, JoinScanConverter, has the correct implementation, and that works fine for JOINs that has reference to WITH queries. So I believe we should delete the incorrect JoinScanWithRefConverter class and move to the other one.

Issue Links

• blocks: BEAM-10238 [Umbrella] Improve Beam ZetaSQL type system
• links to: GitHub Pull Request #12648