Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-10757

Python license check precommit broken for enum34

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P0
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: test-failures
    • Labels:
      None

      Description

      ```
      ERROR:root:Error occurred when pull license for enum34 from

      {'license': 'https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE'}

      .
      16:06:02 Traceback (most recent call last):
      16:06:02 File "/tmp/license_scripts/pull_licenses_py.py", line 94, in pull_from_url
      16:06:02 url_read = urlopen(config['license'])
      16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 154, in urlopen
      16:06:02 �[0m�[91m return opener.open(url, data, timeout)
      16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 435, in open
      16:06:02 response = meth(req, response)
      16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 548, in http_response
      16:06:02 'http', request, response, code, msg, hdrs)
      16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 473, in error
      16:06:02 return self._call_chain(*args)
      16:06:02 �[0m�[91m File "/usr/local/lib/python2.7/urllib2.py", line 407, in _call_chain
      16:06:02 result = func(*args)
      16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 556, in http_error_default
      ```

      I am not sure where is the source of truth for the license now. We can retrieve the license from a released container, check it in Beam repo and reference it as a manual license, see, for example: https://github.com/apache/beam/blob/0d362dd4d2d660b4cdf40f6b87b3fa10965098e1/sdks/python/container/license_scripts/dep_urls_py.yaml#L108.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jkff Eugene Kirpichov
                Reporter:
                tvalentyn Valentyn Tymofieiev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h