Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-10604

Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-java-core

    Description

      https://github.com/apache/beam/blob/6fdde4f4eab72b49b10a8bb1cb3be263c5c416b5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L215

      Can we remove the "final" modifier here so subclasses have the option to override? I have a subclass implementation that performs best with a different size estimation heuristic. Similar case with the #split method.

      Attachments

        Activity

          People

            Unassigned Unassigned
            clairemcginty Claire McGinty
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: