[BEAM-10550] Update solution for ZetaSQL DOUBLE NaN equals checks.

• Type: Improvement
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Component/s: dsl-sql-zetasql
• Assignee: Unassigned
• Reporter: Zijie Song
• Created: 21/Jul/20 21:15
• Updated: 04/Jun/22 17:08

Description

'NaN == NaN' for ZetaSQL DOUBLE type should be false. But it would hit into the Calcite operation simplification block to be simplified to 'null or NaN is not null' in Calcite. This would miscalculate the expression to be true.

Currently, we add an additional random parameter for the wrapper function of NaN, to avoid
triggering Calcite operation simplification. But it is only a temporary solution.

Once the Calcite version updated, we should replace this method by overriding isDeterministic() for RexNode to make it false.

Issue Links

• is blocked by: BEAM-9379 Upgrade to Calcite 1.26.0