Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-10550

Update solution for ZetaSQL DOUBLE NaN equals checks.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: dsl-sql-zetasql
    • Labels:
      None

      Description

      'NaN == NaN' for ZetaSQL DOUBLE type should be false. But it would hit into the Calcite operation simplification block to be simplified to 'null or NaN is not null' in Calcite. This would miscalculate the expression to be true.

      Currently, we add an additional random parameter for the wrapper function of NaN, to avoid
      triggering Calcite operation simplification. But it is only a temporary solution.

      Once the Calcite version updated, we should replace this method by overriding isDeterministic() for RexNode to make it false.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                zijiesong Zijie Song
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: