[BEAM-10479] UDF / UDAF support for ZetaSQLQueryPlanner

• Type: New Feature
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: Missing
• Component/s: dsl-sql-zetasql
• Assignee: Unassigned
• Reporter: Jacob Ferriero
• Created: 14/Jul/20 02:31
• Updated: 13/Jan/22 21:49
• Resolved: 15/May/21 17:57

Description

BeamSqlDslUdfUdafTest should be refactored so each test runs against all supported Query Planners (namely Calcite and Zeta SQL).

This could be achieved without code duplication by using Parameterized tests and having each test run with both query planners (and easily support adding more QueryPlanners in the future if necessary).

import org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner;
import org.apache.beam.sdk.extensions.sql.impl.CalciteQueryPlanner;

@RunWith(Parameterized.class)
public class BeamSqlDslUdfUdafTest extends BeamSqlDslBase {

   public QueryPlanner planner;

  @Parameters(name = "{0}")
  public static Collection<Class<? extends QueryPlanner>> planners(){
    return Arrays.asList(
      CalciteQueryPlanner.class,
      ZetaSQLQueryPlanner.class)
  }

  BeamSqlDslUdfUdafTest(Class<? extends QueryPlanner> planner){
    this.planner = planner;
  }

  // TODO refactor each test that run SqlTransform::query to use SqlTransform::withQueryPlannerClass(this.planner)
  ...
}

Issue Links

• duplicates: BEAM-10943 Support SqlTransform.registerUdf in ZetaSQL dialect