[BEAM-10243] Incorrect checkState condition in withFieldValues in Row.java

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.22.0
• Fix Version/s: 2.24.0
• Component/s: sdk-java-core
• Labels: Done
• Assignee: Kyle Weaver
• Reporter: Pedro Teixeira
• Created: 11/Jun/20 16:18
• Updated: 06/Oct/20 21:51
• Resolved: 08/Jul/20 20:00

Description

 

In the following code:

public FieldValueBuilder withFieldValues(Map<String, Object> values) { 
   checkState(values.isEmpty()); 
   return new FieldValueBuilder(schema, null).withFieldValues(values); 
}  

 

checkState should check `this.values` instead of the passed arguments.

The issue is that as it is now, we cannot use this function to build a Row from Map.

 

thanks.

 

Issue Links

• is duplicated by: BEAM-10918 Row.withSchema.withFieldValues(Map) is broken
• links to: GitHub Pull Request #12200