[BEAM-10227] python_version qualifiers are ignored for typing dependency.

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.23.0
• Component/s: sdk-py-core
• Assignee: Valentyn Tymofieiev
• Reporter: Valentyn Tymofieiev
• Created: 09/Jun/20 21:55
• Updated: 10/Jun/20 16:58
• Resolved: 10/Jun/20 16:58

Description

 
:~$ docker -- run -it --entrypoint=/bin/bash  gcr.io/cloud-dataflow/v1beta3/python3:2.22.0
root@bcd3693fbfa1:/# python --version
Python 3.5.9

root@bcd3693fbfa1:/#  pip install 'typing; python_version < "3.5"'
Ignoring typing: markers 'python_version < "3.5"' don't match your environment

root@bcd3693fbfa1:/#  pip install 'typing; python_version < "3.5.3"'
Collecting typing
  Downloading typing-3.7.4.1-py3-none-any.whl (25 kB)
Installing collected packages: typing
Successfully installed typing-3.7.4.1

The second download should not be happening according to the expressed intent, but it does. using python_full_version fixes that. See also: https://www.python.org/dev/peps/pep-0508/.

Issue Links

• links to: GitHub Pull Request #11962