Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-10169

ParDo* functions should declare the correct output N in their error message

Details

    • Improvement
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • None
    • Not applicable
    • sdk-go

    Description

      User report noted the confusion in the error if you use a DoFn with 0 outputs with beam.ParDo instead of beam.ParDo0.

      In that case, a panic stack trace is followed by the cryptic: "expected 1 output. Found: []"

      We can do better.

      While we can't change the return signature dynamically (that's for ParDoN only), we can instead clearly indicate:

      • the DoFn in question.
      • the number of outputs the DoFn has
      • and recommend using ParDo0, ParDo, ParDo2,...ParDo7, or ParDoN, as appropriate.

      https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/pardo.go#L361 would need to change as well as any of the specific cases that follow.

      Attachments

        Activity

          People

            codeBehindMe Aaron Tillekeratne
            lostluck Robert Burke
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 8h 10m
                8h 10m