Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-10003

Need two PR to submit snippets to website

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • None
    • 2.21.0
    • website
    • None

    Description

      Looks like build_github_samples.sh uses code already on the repo to build local serving;

      do
        fileName=$(echo "$url" | sed -e 's/\//_/g')
        curl -o "$DIST_DIR"/"$fileName" "https://raw.githubusercontent.com$url"
      done

      So when tying to test locally, the code needs to have already be in Beam. 

      Ideally the script should make use of local code when building so :

      1- Easier to  build & test changes.
      2- No need to raise two PR for what is a single change

       

      Attachments

        Issue Links

          Activity

            People

              aizhamal Aizhamal Nurmamat kyzy
              rarokni@gmail.com Reza ardeshir rokni
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h
                  3h