[BCEL-81] ClassParser.parse() throws NullPointerException if class does not exist and ClassParser(String) constructor is used

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.0
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=39770
• External issue ID: 39770
• Assignee: Apache Commons Developers
• Reporter: Alex Kinneer
• Created: 09/Jun/06 21:23
• Updated: 14/Jul/16 12:48
• Resolved: 10/Mar/07 06:55

Description

Reproduce:

ClassParser cp = new ClassParser("does/not/exist/Classfile.class");
JavaClass jc = cp.parse();
--> throws NullPointerException instead of FileNotFoundException

The problem is that when the constructor that accepts a string is used, the
fileOwned flag is set and parse() attempts to close the file in the finally
block. The guarded region for the finally block includes the attempt to open the
input stream, which may fail, but the finally block itself erroneously assumes
the input stream object has been created.

Previously this situation caused the method to correctly throw a
FileNotFoundException.