[BCEL-321] Refactor subclasses of ClassPathRepository for differences in underlying cache

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 6.4.0
• Assignee: Unassigned
• Reporter: Tomo Suzuki
• Created: 17/Jun/19 12:33
• Updated: 10/Jul/19 14:50
• Resolved: 10/Jul/19 12:47

Description

(After implementing BCEL-320)

BCEL has different ClassPathRepository classes with slight modification in its underlying cache:

• ClassPathRepository uses HashMap<String, JavaClass> for JavaClass cache
• MemorySensitiveClassPathRepository uses HashMap<String, SoftReference<JavaClass>
• New LruCacheClassPathRepository by BCEL-320 will use LinkedHashMap<String, JavaClass> for JavaClass cache

The logic of loadClass, storeClass, and findClass methods are almost same (attached screenshot of ClassPathRepository and MemorySensitiveClassPathRepository as below). I think they can leverage an abstraction over the internal cache so that they will have less duplicate code.

After BCEL-320, I'm thinking to create a PR for the abstraction.

Issue Links

• links to: GitHub Pull Request #29