[BCEL-289] Crash when parsing constructor of inner classes with parameters annotated

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 6.0
• Fix Version/s: 6.1
• Component/s: Parser
• Assignee: Bruno P. Kinoshita
• Reporter: Pietro Ferrara
• Created: 16/May/17 14:52
• Updated: 18/Sep/17 09:12
• Resolved: 19/May/17 06:43

Description

BCEL crashes when parsing the constructor of an inner class whose parameters are annotated. For instance, when parsing the jar obtained from the following classes:

public @interface A {}
public @interface B {}
public class Test {
    public class Inner {
	public Inner(@A Object a, @B Object b) {}
    }
}

In particular:

		ClassParser cp = new ClassParser(args[0]);
		ClassGen cg = new ClassGen(cp.parse());
		MethodGen mg = new MethodGen(cg.getMethodAt(0), cg.getClassName(), cg.getConstantPool());
		mg.getAnnotationsOnParameter(0);

(where args[0] points to Test$Inner.class)

you get

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 2
	at org.apache.bcel.generic.MethodGen.ensureExistingParameterAnnotationsUnpacked(MethodGen.java:1120)
	at org.apache.bcel.generic.MethodGen.getAnnotationsOnParameter(MethodGen.java:1073)

Issue Links

• links to: GitHub Pull Request #13
• links to: Pull request 13