[BCEL-209] Bug fixes and improvements to InvokeDynamic and BootStrapMethods implementation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.0
• Assignee: Charles Honton
• Reporter: Mark Roberts
• Created: 05/Feb/15 18:29
• Updated: 14/Jul/16 12:48
• Resolved: 19/Jul/15 21:11

Description

(Apologies in advance - this is a very large diff.)
During the past year, both the Apache Commons BCEL team and our group here at the UW independently completed the support for InvokeDynamic . Some things we chose to do the same way, but there are a few items that are quite different. Trying not to be too biased, I believe our method is better. One of the larger differences is your decision to add the abstract class NameSignatureMethod between FieldOrMethod and CPInstruction and then have InvokeDynamic extend from that instead of from InvokeInstruction. To me this seems wrong. In addition to forcing InvokeDynamic to duplicate all the methods from InvokeInstruction and FieldOrMethod, it is awkward that it is the only form of the Invoke Instruction that doesn't derive from InvokeInstruction.

This patch also includes several methods missing from the current implementation: alternative initializers, toString, and support for the Visitor paradigm.

There are bug fixes to Constants.java and InstructionFinder.java as well.

Issue Links

• is duplicated by: BCEL-213 invokedynamic support for InstructionFinder