Uploaded image for project: 'Commons BCEL'
  1. Commons BCEL
  2. BCEL-165

getAnnotationEntries methods in JavaClass and FieldOrMethod duplicate code

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: unspecified
    • Fix Version/s: 6.0
    • Component/s: Main
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Macintosh

      Description

      JavaClass.getAnnotationEntries() and FieldOrMethod.getAnnotationEntries() are overly complex.

      FieldOrMethod.addAnnotationEntry() appears to be in the wrong place - FieldGenOrMethodGen.addAnnotationEntry() is the proper method to use.

        Attachments

        1. refactorGetAnnotations.diff
          6 kB
          Charles Honton

          Activity

            People

            • Assignee:
              issues@commons.apache.org Apache Commons Developers
              Reporter:
              chonton Charles Honton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: