[BCEL-148] BCELifier produces incorrect code for methods containing loads of class literals from constant pool

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 6.8.1
• Fix Version/s: 6.0
• Component/s: Main
• Labels: PatchAvailable
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=49615
• Severity: normal
• Priority: P2
• External issue ID: 49615
• Assignee: Apache Commons Developers
• Reporter: Tassos Bassoukos
• Created: 19/Jul/10 09:22
• Updated: 07/Dec/23 21:04
• Resolved: 19/Jul/10 20:29

Description

When a class literal is loaded from the constant pool, the BCELifier produces not compilable code. The attached patch fixes this issue with 3 modifications:

• LDC#getValue(): when a class constant is referenced, return a correct ObjectType instance.
• PUSH: new constructor that takes an ObjectType instance and does the right thing (I hope)
• BCELFactory#createConstant(): if the constant is an ObjectType, produce the correct embedding string.