[BCEL-145] Type.getReturnTypeSize() doesn't decode Type.getTypeSize() output

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 6.0
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=49332
• Severity: blocker
• Priority: P2
• External issue ID: 49332
• Assignee: Apache Commons Developers
• Reporter: William Pugh
• Created: 24/May/10 11:09
• Updated: 07/Dec/23 21:04
• Resolved: 24/May/10 22:06

Description

The Type.getReturnTypeSize() method doesn't decode Type.getTypeSize() output.

The same bug was present in FieldInstruction.getFieldSize(), filed and fixed as BCEL-138 https://issues.apache.org/bugzilla/show_bug.cgi?id=48280

As a result of this bug, the BCEL calculates the wrong size of the return type for methods, leading to FindBugs going off the rails.

The fix is the same as to fix FieldInstruction.getFieldSize(): use Type.size() to decode the coded value.
I've attached a patch with the fix, and I've also looked at the other uses of getTypeSize(), and all the other invocations seem OK.