[BCEL-138] FieldInstruction.getFieldSize() doesn't decode Type.getTypeSize() output

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 6.0
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=48280
• Severity: normal
• Priority: P2
• External issue ID: 48280
• Assignee: Apache Commons Developers
• Reporter: Enrico Gueli
• Created: 25/Nov/09 03:25
• Updated: 07/Dec/23 21:04
• Resolved: 10/Jan/10 12:33

Description

The method getTypeSize(String) in the Type class returns two outputs encoded in one integer: the lowest two bits contain the field size (0, 1 or 2), the remaining ones the no. of consumed characters in the signature. Type provides two private static methods, size() and consumed(), to split these values apart.

The method getFieldSize(ConstantPoolGen) in the FieldInstrucion class uses Type.getTypeSize, unaware that the output is encoded. Therefore, the returned size is different than expected. This causes, among other things, a bigger or smaller max stack depth value for generated methods that leads to unused stack memory or a "java.lang.VerifyError: stack size too large" exception, respectively.

A fix can be made by making the above-mentioned static methods package-visible and modifying getFieldSize() to use them.