Uploaded image for project: 'Batik'
  1. Batik
  2. BATIK-739

Suggestion for clarification in UpdateManager.interrupt comment

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Resolution: Unresolved
    • Affects Version/s: 1.7
    • Fix Version/s: None
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      Operating System: Linux
      Platform: PC

      Description

      A suggestion for additional information that could be included to explain the
      empty catch clause in the UpdateManager.interrupt comment:

      // An IllegalStateException can be thrown by the RunnableQueue.resumeExecution()
      method, due to a race condition: The RunnableQueue.preemptLater method call
      starts the process of killing the RunnableQueue thread, which could finish
      before the resumeExecution method is called. Additional synchronization might
      fix this, but it's easy and effective to discard the redundant exception.

      (I ran into this while tracking real IllegalStateException cases caused by our
      code. It took a little research to determine that this IllegalStateException is
      NOT a problem. So it might save other developers some confusion and effort if
      additional comments were present.)

        Attachments

          Activity

            People

            • Assignee:
              batik-dev@xmlgraphics.apache.org Batik Developer's Mailing list
              Reporter:
              jeff.grigg@asolutions.com Jeff Grigg
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: