[BATIK-623] strange looking equals

• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Affects Version/s: 1.6
• Component/s: CSS
• Environment: Operating System: other; Platform: All
• Assignee: Batik Developer's Mailing list
• Reporter: Dieter von Holten
• Created: 26/Feb/06 13:46
• Updated: 04/Mar/06 18:54
• Resolved: 04/Mar/06 18:54

Description

in batik.css.engine.sac.AbstractElementSelector i found an equals-method like this:
public boolean equals( Object obj ) {
if ( obj == null || !( obj.getClass() != getClass() ))

{ return false; }

... other comparisons ...

The double negated class-compare doesnt make sense to me. The intention seems to
be to reject checks against other classes. I 'd do it with instanceof.
The same code exists in AbstractAttributeCondition, AbstractCombinatorCondition,
AbstractDescendantSelector, AbstractSiblingSelector, CSSConditionalSelector,
CSSLangCondition.