[BATIK-520] Some UpdateManager Events fired in UpdateManager are constructed with a "source" as an anonymous inner class

• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Affects Version/s: 1.5
• Component/s: Bridge
• Environment: Operating System: Windows 2000; Platform: PC
• Assignee: Batik Developer's Mailing list
• Reporter: Ian Sollars
• Created: 29/Nov/04 22:52
• Updated: 16/Feb/05 16:53
• Resolved: 16/Feb/05 16:53

Description

On several locations within org.apache.batik.bridge.UpdateManager,
UpdateManagerEventS are created inside anonymous inner classes with a reference
to "this" as the source of the event, as opposed to "UpdateManager.this".

Run and confirmed against batik 1.5.1, using j2sdk1.4.2_03 on W2KS.

Line numbers (on the Feb 20 release):

Lines 234 and 365: inside new Runnable()

{...}

Line 577 and 590: inside UpdateManager.UpdateManagerRunHander:
executionSuspended()
executionResumed()

Demonstration code:

(snipped from an instance of an UpdateManagerListener implementation subscribed
at least one JSVGComponent.)

public void managerStarted(UpdateManagerEvent evt) {
System.out.println("evt.getSource().getClass()="+evt.getSource().getClass());
}

Observed output:

evt.getSource().getClass()=class org.apache.batik.bridge.UpdateManager$8

(note the "$8" denoting an anonymous inner class.)

Expected output:

e.getSource().getClass()=class org.apache.batik.bridge.UpdateManager

Regards,

• Ian

(P.S: Batik rocks.)