[BATIK-495] ConcurrentModificationException in UpdateTracker.getDirtyAreas() - ASF JIRA

Details

Type: Bug
Status: Resolved
Resolution: Fixed
Affects Version/s: 1.5
Fix Version/s: None
Component/s: GVT
Labels:
None
Environment:
Operating System: Linux
Platform: PC

Description

UpdateTracker is not intended to be
thread safe, but UpdateTracker.changeStarted() is
called outside the UpdateManager thread when resizing
the SVGCanvas. sometimes this could finnish with a
ConcurrentModificationException in UpdateManager... no more refreshing...

Tested on linux mandrake 10.0,
JDK: IBM JDK 1.4.1 and sun JDK 1.4.2_04
batik 1.5.1

Here is a test case:
just save map.svg, compile TestSVG, run and resize several times the window.
The program terminates as soon as RunnableQueue is broken (it takes only few
seconds when resizing the window continuously).

TestSVG.java:

import java.util.Random;

import javax.swing.JFrame;

import org.apache.batik.swing.JSVGCanvas;
import org.apache.batik.util.RunnableQueue;
import org.w3c.dom.Element;
import org.w3c.dom.NodeList;

/**

@author yann
*/
public class TestSVG extends JFrame {
JSVGCanvas c;

String nomsvg = "map.svg";

public TestSVG() {
super();
c = new JSVGCanvas();

c.setDocumentState(JSVGCanvas.ALWAYS_DYNAMIC);
c.setEnableImageZoomInteractor(false);
c.setEnablePanInteractor(false);
c.setEnableResetTransformInteractor(false);
c.setEnableRotateInteractor(false);
c.setEnableZoomInteractor(false);
c.setURI("file://" + nomsvg);

getContentPane().add(c);
setSize(400, 400);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
show();

//wait until we can play...
while (c.getUpdateManager() == null) {
try

{ Thread.sleep(1000); } catch (InterruptedException ie) {
}
}
while (c.getUpdateManager().getUpdateRunnableQueue() == null) {
try { Thread.sleep(1000); }

catch (InterruptedException ie) {
}
}
RunnableQueue q = c.getUpdateManager().getUpdateRunnableQueue();

// everything ok.
int cpt = 0;
while (true) { // modify continuously the svg document
// the svgcanvas is often repainted
// which make the problem appear soon
cpt++;
try {
q.invokeLater(new Runnable() {
public void run() {
NodeList nl = c.getSVGDocument().getElementsByTagName(
"path");
for (int i = 0; i < nl.getLength(); i++)

{ Element e = (Element) nl.item(i); e.setAttribute("style", "fill:rgb(" + r.nextInt(255) + "," + r.nextInt(255) + "," + r.nextInt(255) + ")"); }

}
});
if (cpt % 100 == 0)
Thread.sleep(200);
} catch (Exception e)

{ // RunnableQueue may be broken... IllegalStateException e.printStackTrace(); System.exit(0); }

}

public static Random r = new Random();

public static void main(String[] args)

{ new TestSVG(); }

}

map.svg:

<?xml version="1.0" encoding="UTF-8"?>

</svg>

Here are stack traces for AWTEventDispatchThread (the code called when the
canvas is resized) and
the ConcurrentModificationException in UpdateManager (crash of the RunnableQueue):

java.lang.Exception: Stack trace
at java.lang.Thread.dumpStack(Thread.java:1103)
at org.apache.batik.gvt.UpdateTracker.changeStarted(Unknown Source)
at
org.apache.batik.gvt.AbstractGraphicsNode.fireGraphicsNodeChangeStarted(Unknown
Source)
at
org.apache.batik.gvt.AbstractGraphicsNode.fireGraphicsNodeChangeStarted(Unknown
Source)
at org.apache.batik.gvt.CanvasGraphicsNode.setViewingTransform(Unknown Source)
at org.apache.batik.swing.svg.JSVGComponent.updateRenderingTransform(Unknown
Source)
at org.apache.batik.swing.gvt.JGVTComponent$1.componentResized(Unknown Source)
at java.awt.AWTEventMulticaster.componentResized(AWTEventMulticaster.java:125)
at java.awt.Component.processComponentEvent(Component.java:5120)
at java.awt.Component.processEvent(Component.java:5074)
at java.awt.Container.processEvent(Container.java:1607)
at java.awt.Component.dispatchEventImpl(Component.java:3754)
at java.awt.Container.dispatchEventImpl(Container.java:1664)
at java.awt.Component.dispatchEvent(Component.java:3582)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:531)
at
java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:238)
at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:182)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:176)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:168)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:131)

java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java(Compiled Code))
at java.util.HashMap$KeyIterator.next(HashMap.java(Compiled Code))
at org.apache.batik.gvt.UpdateTracker.getDirtyAreas(Unknown Source)
at org.apache.batik.bridge.UpdateManager.repaint(Unknown Source)
at
org.apache.batik.bridge.UpdateManager$UpdateManagerRunHander.runnableInvoked(Unknown
Source)
at org.apache.batik.util.RunnableQueue.runnableInvoked(Unknown Source)
at org.apache.batik.util.RunnableQueue.run(Unknown Source)
at java.lang.Thread.run(Thread.java:568)

ConcurrentModificationException in UpdateTracker.getDirtyAreas()

Details

Description

Attachments

Activity

People

Dates